fix: fix race conditions #4074
Open
fix: fix race conditions #4074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kzys
force-pushed
the
test-deploy-machines-app
branch
from
0551ca5
to
f36e8d0
Compare
This test is a by-product of my investigation. The investigation resulted a server-side fix, but the test itself and some doc comments may be useful.
kzys
force-pushed
the
test-deploy-machines-app
branch
4 times, most recently
from
1c8c528
to
351bbe0
Compare
There are multiple race conditions we've missed. Our unit tests are running with -race, but we don't have much unit tests around deploy package.
kzys
force-pushed
the
test-deploy-machines-app
branch
from
351bbe0
to
f70a750
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test was a by-product of my investigation. The investigation resulted a server-side fix, but the test itself and some doc comments would be useful.
... then the test found multiple race conditions :)
Change Summary
What and Why:
How:
Related to:
Documentation