Add option to configure fly by env #3789
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubys
approved these changes
Jul 27, 2024
There was a problem hiding this comment.
Even though you described what you were doing quite clearly, it took me a minute or two to figure out what this was doing. If would be a good idea for Michael and/or Ben to review this too.
We currently have FLY_ORG. This change would generalize this to pretty much any flag on any command.
rubys
reviewed
Jul 30, 2024
| if strings.ToUpper(parent.Name()) == "FLY" { | ||
| return *cmd | ||
| func EnvNameFromCmd(cmd *cobra.Command) string { | ||
| if cmd.Parent() != nil { |
There was a problem hiding this comment.
Does this break existing users of FLY_ORG?
There was a problem hiding this comment.
No, I broke that elsewhere; this is the "fix", but with a caveat:
FLY_ORG by itself as an env var will do what you expect, but if you for instance do FLY_LAUNCH_ORG, that will get precedence. Some examples:
list apps for org xxx:
FLY_ORG=xxx fly apps list list apps for org yyy:
FLY_APPS_ORG=yyy fly apps listlist apps for org yyy:
FLY_ORG=xxx FLY_APPS_ORG=yyy fly apps list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
What and Why:
Allow config to be set by env vars for most flags.
Let's say you're managing multiple infrastructure setups, it can be be convenient to have certain flags/options set in the environment; this is a "one-size" solution for that; the precedence is still any flags you might specify, but if no flag is specified, we check for the corresponding env var (which is all-caps,
FLY_prefixed stuff).This is a draft/idea for now - I'd love to have a discussion about whether this makes sense or not :)