fix: properly compute socket usage #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hauleth
force-pushed
the
fix/properly-compute-socket-usage
branch
from
11f3f10 to
08c0ae9
Compare
abc3
approved these changes
Dec 13, 2024
This partially reverts commit 4b49887. The change was not properly implementing previous behaviour in presence of multiple sockets reporting to the same set of attributes. Instead of summing their usage it was reporting only the latest one.
hauleth
force-pushed
the
fix/properly-compute-socket-usage
branch
from
08c0ae9 to
8ea48d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partially reverts commit 4b49887.
The change was not properly implementing previous behaviour in presence of multiple sockets reporting to the same set of attributes. Instead of summing their usage it was reporting only the latest one.