feat: shorter retry connect timeout for proxy mode #462
+28
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hauleth
approved these changes
Oct 9, 2024
| @@ -1120,7 +1120,7 @@ defmodule Supavisor.ClientHandler do | |||
| @spec timeout_subscribe_or_terminate(map()) :: :gen_statem.handle_event_result() | |||
| def timeout_subscribe_or_terminate(%{subscribe_retries: subscribe_retries} = data) do | |||
| if subscribe_retries < @subscribe_retries do | |||
| Logger.warning("ClientHandler: Retry subscribe") | |||
| Logger.warning("ClientHandler: Retry subscribe #{inspect(subscribe_retries)}") | |||
There was a problem hiding this comment.
We need to implement structured logging in Supavisor.
hauleth
approved these changes
Oct 11, 2024
abc3
force-pushed
the
feat/retry_timeout
branch
from
703ad15 to
4b7f7fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.