Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: s3 post handler #594

Merged
merged 1 commit into from
Dec 31, 2024
Merged

feat: s3 post handler #594

merged 1 commit into from
Dec 31, 2024

Conversation

fenos
Copy link
Contributor

@fenos fenos commented Dec 2, 2024

What kind of change does this PR introduce?

Feature

What is the new behavior?

  • Support for POST Upload for the S3 Protocol
  • Major refactor to the Uploader class so that it is not coupled to the FastifyRequest allowing for much more granular control on how to upload files depending on the method we receive the stream

TODO: Upload conditions

[EDIT]

Upload conditions will be implemented in a future PR.
The only condition that is now support is Expiry

Copy link

github-actions bot commented Dec 2, 2024

Pull Request Test Coverage Report for Build 12560255481

Details

  • 510 of 543 (93.92%) changed or added relevant lines in 13 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.2%) to 78.083%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/http/plugins/signature-v4.ts 30 31 96.77%
src/http/routes/tus/lifecycle.ts 1 2 50.0%
src/storage/protocols/s3/s3-handler.ts 16 17 94.12%
src/http/routes/s3/index.ts 17 21 80.95%
src/storage/protocols/s3/signature-v4.ts 91 95 95.79%
src/http/routes/s3/commands/put-object.ts 147 157 93.63%
src/storage/uploader.ts 140 152 92.11%
Files with Coverage Reduction New Missed Lines %
src/storage/uploader.ts 2 87.69%
Totals Coverage Status
Change from base Build 12372862665: 0.2%
Covered Lines: 14216
Relevant Lines: 18056

💛 - Coveralls

@fenos fenos force-pushed the feat/s3-post-form branch from 2b72f42 to a20eec6 Compare December 31, 2024 13:27
@fenos fenos force-pushed the feat/s3-post-form branch from a20eec6 to 907a304 Compare December 31, 2024 13:39
@fenos fenos merged commit d6db70e into master Dec 31, 2024
1 check passed
@fenos fenos deleted the feat/s3-post-form branch December 31, 2024 13:45
Copy link

🎉 This PR is included in version 1.15.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants