Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: s3 post handler #594

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: s3 post handler #594

wants to merge 1 commit into from

Conversation

fenos
Copy link
Contributor

@fenos fenos commented Dec 2, 2024

What kind of change does this PR introduce?

Feature

What is the new behavior?

  • Support for POST Upload for the S3 Protocol
  • Major refactor to the Uploader class so that it is not coupled to the FastifyRequest allowing for much more granular control on how to upload files depending on the method we receive the stream

TODO: Upload conditions

Copy link

github-actions bot commented Dec 2, 2024

Pull Request Test Coverage Report for Build 12120896957

Details

  • 501 of 530 (94.53%) changed or added relevant lines in 13 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.2%) to 78.08%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/http/plugins/signature-v4.ts 29 30 96.67%
src/http/routes/tus/lifecycle.ts 1 2 50.0%
src/storage/protocols/s3/s3-handler.ts 16 17 94.12%
src/storage/protocols/s3/signature-v4.ts 91 95 95.79%
src/http/routes/s3/commands/put-object.ts 143 153 93.46%
src/storage/uploader.ts 141 153 92.16%
Files with Coverage Reduction New Missed Lines %
src/storage/uploader.ts 2 87.71%
Totals Coverage Status
Change from base Build 12067007851: 0.2%
Covered Lines: 14169
Relevant Lines: 17999

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants