Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support x-forwarded-path #579

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Conversation

fenos
Copy link
Contributor

@fenos fenos commented Nov 1, 2024

What kind of change does this PR introduce?

Feature

What is the new behavior?

Allow supporting x-forwarded-path to determine paths dynamically for generated URL

Additional context

Opt-in feature with the env var: REQUEST_ALLOW_X_FORWARDED_PATH

Copy link

github-actions bot commented Nov 1, 2024

Pull Request Test Coverage Report for Build 11626096905

Details

  • 14 of 18 (77.78%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 77.9%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/http/plugins/signature-v4.ts 5 7 71.43%
src/http/routes/tus/lifecycle.ts 6 8 75.0%
Totals Coverage Status
Change from base Build 11479096745: -0.02%
Covered Lines: 13917
Relevant Lines: 17722

💛 - Coveralls

@fenos fenos force-pushed the feat/support-x-forwarded-path branch 2 times, most recently from 7207864 to 63fbb2a Compare November 5, 2024 14:04
@fenos fenos force-pushed the feat/support-x-forwarded-path branch from 63fbb2a to 42e0dcf Compare November 7, 2024 15:30
@fenos fenos merged commit a35f159 into master Nov 11, 2024
1 check passed
@fenos fenos deleted the feat/support-x-forwarded-path branch November 11, 2024 10:46
Copy link

🎉 This PR is included in version 1.13.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants