Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow increasing resolution on a per tenant basis #574

Merged
merged 1 commit into from
Oct 21, 2024
Merged

feat: allow increasing resolution on a per tenant basis #574

merged 1 commit into from
Oct 21, 2024

Conversation

fenos
Copy link
Contributor

@fenos fenos commented Oct 21, 2024 •
edited
Loading

What kind of change does this PR introduce?

Feature

What is the new behavior?

Allow customising the max_resolution limit that imgproxy will impose for specific tenants.
Default is NULL (default)

this env IMGPROXY_ALLOW_SECURITY_OPTIONS is necessary in imgproxy for this to work

@fenos fenos force-pushed the multitenant/allow-increase-img-transform-res-per-tenant branch from 40c13af to f2422e5 Compare October 21, 2024 13:42
@fenos fenos force-pushed the multitenant/allow-increase-img-transform-res-per-tenant branch from f2422e5 to a63ed35 Compare October 21, 2024 14:53
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11442836776

Details

  • 46 of 68 (67.65%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.06%) to 77.969%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/internal/database/tenant.ts 1 3 33.33%
src/http/routes/render/renderAuthenticatedImage.ts 4 9 44.44%
src/http/routes/render/renderPublicImage.ts 4 9 44.44%
src/http/routes/render/renderSignedImage.ts 5 10 50.0%
src/storage/renderer/image.ts 16 21 76.19%
Totals Coverage Status
Change from base Build 11407221128: -0.06%
Covered Lines: 13911
Relevant Lines: 17701
💛 - Coveralls

@fenos fenos merged commit f0c6953 into master Oct 21, 2024
1 check passed
@fenos fenos deleted the multitenant/allow-increase-img-transform-res-per-tenant branch October 21, 2024 15:10
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 1.12.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inian inian inian approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fenos @coveralls @inian