Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Watch upload stream + fix duplicate logs #559

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Conversation

fenos
Copy link
Contributor

@fenos fenos commented Sep 30, 2024

What kind of change does this PR introduce?

Bug fix

What is the new behavior?

  • This PR fixes the edge case where aborted request prints logs twice
  • Add a passthrough stream which watches the data flowing
  • on Abort we add to the trace bytes uploaded and bytes read

@fenos fenos force-pushed the fix/prevent-duplicate-logs branch from b2d52d6 to 32ce1e4 Compare September 30, 2024 16:18
@coveralls
Copy link

coveralls commented Sep 30, 2024

Pull Request Test Coverage Report for Build 11140263069

Details

  • 147 of 233 (63.09%) changed or added relevant lines in 10 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.2%) to 78.414%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/http/plugins/tracing.ts 0 1 0.0%
src/internal/concurrency/stream.ts 38 40 95.0%
src/storage/protocols/s3/signature-v4.ts 0 2 0.0%
src/internal/errors/codes.ts 3 8 37.5%
src/http/plugins/signals.ts 5 11 45.45%
src/http/plugins/log-request.ts 3 10 30.0%
src/http/error-handler.ts 2 13 15.38%
src/storage/protocols/s3/s3-handler.ts 1 21 4.76%
src/storage/backend/s3.ts 94 126 74.6%
Files with Coverage Reduction New Missed Lines %
src/storage/backend/s3.ts 1 83.7%
src/http/plugins/signals.ts 2 84.13%
Totals Coverage Status
Change from base Build 11106554547: -0.2%
Covered Lines: 13821
Relevant Lines: 17481

💛 - Coveralls

@fenos fenos force-pushed the fix/prevent-duplicate-logs branch from 32ce1e4 to a08713b Compare October 1, 2024 16:35
@fenos fenos changed the title fix: prevent duplicate logs Watch upload stream + fix duplicate logs Oct 2, 2024
@fenos fenos force-pushed the fix/prevent-duplicate-logs branch from a08713b to 2a39281 Compare October 2, 2024 07:47
@fenos fenos force-pushed the fix/prevent-duplicate-logs branch from 2a39281 to 6922702 Compare October 2, 2024 08:17
@fenos fenos merged commit 35f9d4f into master Oct 2, 2024
1 check passed
@fenos fenos deleted the fix/prevent-duplicate-logs branch October 2, 2024 09:18
Copy link

github-actions bot commented Oct 2, 2024

🎉 This PR is included in version 1.11.9 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants