Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add more tracing on Uploader #558

Merged
merged 1 commit into from
Sep 30, 2024
Merged

fix: add more tracing on Uploader #558

merged 1 commit into from
Sep 30, 2024

Conversation

fenos
Copy link
Contributor

@fenos fenos commented Sep 30, 2024

What kind of change does this PR introduce?

Monitoring

What is the new behavior?

  • Add tracing to more methods on the aws/s3-client
  • pass abort signal to the createObject method
  • convert std library imports to node ejs style
  • add delay to close connection when aborting

@coveralls
Copy link

coveralls commented Sep 30, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11106407487

Details

  • 85 of 115 (73.91%) changed or added relevant lines in 12 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.05%) to 78.636%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/http/plugins/log-request.ts 70 72 97.22%
src/http/plugins/tracing.ts 0 28 0.0%
Totals Coverage Status
Change from base Build 11009891242: -0.05%
Covered Lines: 13722
Relevant Lines: 17307
💛 - Coveralls

@fenos fenos force-pushed the traces/add-more-traces branch 2 times, most recently from 346e8fa to 3c54388 Compare September 30, 2024 10:45
@fenos fenos force-pushed the traces/add-more-traces branch from 3c54388 to 97d0249 Compare September 30, 2024 12:47
@fenos fenos merged commit da3ce61 into master Sep 30, 2024
1 check passed
@fenos fenos deleted the traces/add-more-traces branch September 30, 2024 12:55
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 1.11.8 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inian inian inian approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fenos @coveralls @inian