Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use a single client #553

Merged
merged 1 commit into from
Sep 24, 2024
Merged

fix: use a single client #553

merged 1 commit into from
Sep 24, 2024

Conversation

fenos
Copy link
Contributor

@fenos fenos commented Sep 23, 2024

What kind of change does this PR introduce?

Chore

What is the new behavior?

  • Revert: single S3 client (no performance gain)
  • try / catch on tracing middleware
  • added appVersion to the logs
  • default s3Timeout 0 (no timeout)

@fenos fenos force-pushed the chore/use-single-s3-client branch from 385d44b to 346112f Compare September 24, 2024 07:40
Copy link

Pull Request Test Coverage Report for Build 11009243548

Details

  • 25 of 64 (39.06%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.05%) to 78.688%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/http/plugins/tracing.ts 0 39 0.0%
Totals Coverage Status
Change from base Build 10956372865: -0.05%
Covered Lines: 13699
Relevant Lines: 17261

💛 - Coveralls

@fenos fenos merged commit bf91ce2 into master Sep 24, 2024
1 check passed
@fenos fenos deleted the chore/use-single-s3-client branch September 24, 2024 08:23
Copy link

🎉 This PR is included in version 1.11.7 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants