Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add metrics for agentkeepalive #551

Merged
merged 1 commit into from
Sep 20, 2024
Merged

fix: add metrics for agentkeepalive #551

merged 1 commit into from
Sep 20, 2024

Conversation

fenos
Copy link
Contributor

@fenos fenos commented Sep 19, 2024 •
edited
Loading

What kind of change does this PR introduce?

Monitoring

What is the new behavior?

  • Adding Prometheus metrics to agentkeepalive pool
  • Adding abort signals to upload
  • More spans on aws Uploader class
  • Updated fastify from 4.8.0 to 4.28.0
  • Updated to typescript 5

@fenos fenos force-pushed the metrics/add-agent-metrics branch from cd8ac32 to 16acbdb Compare September 19, 2024 15:37
@fenos fenos force-pushed the metrics/add-agent-metrics branch 3 times, most recently from ecf4c74 to a0fe880 Compare September 19, 2024 16:54
@github-actions GitHub Actions
Copy link

Pull Request Test Coverage Report for Build 10945462140

Details

  • 146 of 170 (85.88%) changed or added relevant lines in 13 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 78.758%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/storage/backend/adapter.ts 0 4 0.0%
src/storage/protocols/s3/s3-handler.ts 11 15 73.33%
src/storage/backend/s3.ts 75 91 82.42%
Files with Coverage Reduction New Missed Lines %
src/storage/backend/s3.ts 1 87.54%
Totals Coverage Status
Change from base Build 10937127944: 0.02%
Covered Lines: 13726
Relevant Lines: 17278
💛 - Coveralls

@fenos fenos force-pushed the metrics/add-agent-metrics branch 3 times, most recently from 1085f81 to 024ba8c Compare September 20, 2024 07:48
@fenos fenos force-pushed the metrics/add-agent-metrics branch from 024ba8c to 316e66d Compare September 20, 2024 08:23
@fenos fenos merged commit fbdc9d3 into master Sep 20, 2024
1 check passed
@fenos fenos deleted the metrics/add-agent-metrics branch September 20, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inian inian inian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fenos @inian