feat: server times #532
Merged
feat: server times #532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fenos
force-pushed
the
feature/server-timings
branch
2 times, most recently
from
1273fea to
f9f2d17
Compare
inian
approved these changes
Aug 13, 2024
fenos
force-pushed
the
feature/server-timings
branch
from
f9f2d17 to
0287107
Compare
Pull Request Test Coverage Report for Build 10367878030Details
💛 - Coveralls |
fenos
force-pushed
the
feature/server-timings
branch
from
0287107 to
3644e66
Compare
|
🎉 This PR is included in version 1.10.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
feature
What is the new behavior?
This PR optionally introduces serverTimes to response logs and/or response header.
We use Otel Spans and convert them into serverTimes.
We can control the threshold where the
spanwill only be included if the duration will be greater to this value.This is controlled by the
TRACING_SERVER_TIME_MIN_DURATIONenv and is helpful when you just want to log spans above a certain duration.Additional context
TRACING_ENABLED=true/falseenv (default off)TRACING_RETURN_SERVER_TIMINGS=true(default off)