Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow sync migrations #529

Merged
merged 1 commit into from
Aug 5, 2024
Merged

fix: allow sync migrations #529

merged 1 commit into from
Aug 5, 2024

Conversation

fenos
Copy link
Contributor

@fenos fenos commented Aug 5, 2024

What kind of change does this PR introduce?

Improvement

What is the new behavior?

This PR introduces a new ---SYNC--- token in the migrations files which will force the migrations to run before the request is handled.

Once the migrations have run, the service will continue to use progressive migrations.

@fenos fenos force-pushed the migrations/sync-mode branch 2 times, most recently from 5274413 to 2a128ca Compare August 5, 2024 14:02
@coveralls
Copy link

coveralls commented Aug 5, 2024

Pull Request Test Coverage Report for Build 10250741495

Details

  • 14 of 55 (25.45%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 79.402%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/http/plugins/db.ts 1 19 5.26%
src/internal/database/migrations/migrate.ts 13 36 36.11%
Totals Coverage Status
Change from base Build 10245843990: -0.1%
Covered Lines: 13205
Relevant Lines: 16473

💛 - Coveralls

@fenos fenos force-pushed the migrations/sync-mode branch from 2a128ca to d95be79 Compare August 5, 2024 14:05
@fenos fenos force-pushed the migrations/sync-mode branch from d95be79 to 8641032 Compare August 5, 2024 14:29
@fenos fenos merged commit 5a2ffbd into master Aug 5, 2024
1 check passed
@fenos fenos deleted the migrations/sync-mode branch August 5, 2024 14:56
Copy link

github-actions bot commented Aug 5, 2024

🎉 This PR is included in version 1.8.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants