-
-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make operations resilent to Queue disconnection #512
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 9732615382Details
💛 - Coveralls |
fenos
force-pushed
the
storage/webhooks-max-http-connections
branch
4 times, most recently
from
July 2, 2024 10:11
38cb4e8
to
2670782
Compare
Pull Request Test Coverage Report for Build 9759063099Details
💛 - Coveralls |
fenos
force-pushed
the
storage/webhooks-max-http-connections
branch
2 times, most recently
from
July 2, 2024 10:28
d7d2d6d
to
57eebd6
Compare
Pull Request Test Coverage Report for Build 9759296430Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9759314996Details
💛 - Coveralls |
fenos
force-pushed
the
storage/webhooks-max-http-connections
branch
from
July 2, 2024 12:17
57eebd6
to
1d9abbf
Compare
Pull Request Test Coverage Report for Build 9760775005Details
💛 - Coveralls |
fenos
force-pushed
the
storage/webhooks-max-http-connections
branch
from
July 2, 2024 12:33
1d9abbf
to
704a66f
Compare
Pull Request Test Coverage Report for Build 9761028544Details
💛 - Coveralls |
inian
approved these changes
Jul 2, 2024
fenos
force-pushed
the
storage/webhooks-max-http-connections
branch
2 times, most recently
from
July 2, 2024 13:09
f43e017
to
53e40e0
Compare
Pull Request Test Coverage Report for Build 9761565896Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9761587257Details
💛 - Coveralls |
fenos
force-pushed
the
storage/webhooks-max-http-connections
branch
from
July 2, 2024 14:54
53e40e0
to
401752d
Compare
🎉 This PR is included in version 1.6.5 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Pull Request Test Coverage Report for Build 9763276066Details
💛 - Coveralls |
fenos
changed the title
Make operations redundant to Queue disconnection
Make operations resilent to Queue disconnection
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
What is the new behavior?
Dependencies Updates:
Queue:
QUEUE_WEBHOOK_MAX_CONNECTIONS
env to control the HTTP webhook pool sizePG_QUEUE_READ_WRITE_TIMEOUT
env to abort queue operations if above that thresholdPG_QUEUE_MAX_CONNECTIONS
env to control how many connections the Queue can useTenant DB:
timeout
of5s
forwaitObjectLock
Multitenant DB:
Logging:
objectVersion
to the logs for better traceability)metadata
toObjectDelete
eventregion
field top levelFolder Structure:
server.ts,shutdown.ts,worker.ts
, they are now nested inside thestart/
folder@internal/queue