Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow creating folders even if the mime type validation is set #509

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

fenos
Copy link
Contributor

@fenos fenos commented Jun 26, 2024

What kind of change does this PR introduce?

Bug fix

What is the current behavior?

When the mime-type is set, creating empty folders fails

What is the new behavior?

Empty folders can still be created

Closes #503 this PR also restricts emptyFolders to 0kb

@coveralls
Copy link

coveralls commented Jun 26, 2024

Pull Request Test Coverage Report for Build 9675150332

Details

  • 11 of 11 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 80.09%

Totals Coverage Status
Change from base Build 9663883328: 0.02%
Covered Lines: 12781
Relevant Lines: 15811

💛 - Coveralls

@fenos fenos merged commit c2681b8 into master Jun 26, 2024
1 check passed
@fenos fenos deleted the storage/do-not-validate-mime-type-on-empty-folder branch June 26, 2024 07:31
Copy link

🎉 This PR is included in version 1.6.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants