Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/improvements #508

Merged
merged 5 commits into from
Jun 25, 2024
Merged

Chore/improvements #508

merged 5 commits into from
Jun 25, 2024

Conversation

fenos
Copy link
Contributor

@fenos fenos commented Jun 25, 2024

What kind of change does this PR introduce?

Bug fix

What is the new behavior?

  • Automatically push mirrors after release
  • Refactored and tidied up SignatureV4 verify method
  • Webhook event is now using a connection pool
  • always bind the metrics route on the admin app

@coveralls
Copy link

coveralls commented Jun 25, 2024

Pull Request Test Coverage Report for Build 9658392346

Details

  • 59 of 69 (85.51%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 80.023%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/queue/events/webhook.ts 17 27 62.96%
Totals Coverage Status
Change from base Build 9644028748: 0.04%
Covered Lines: 12747
Relevant Lines: 15782

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 25, 2024

Pull Request Test Coverage Report for Build 9662924399

Details

  • 370 of 397 (93.2%) changed or added relevant lines in 99 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 80.075%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/app.ts 0 1 0.0%
src/storage/events/webhook.ts 18 28 64.29%
src/internal/errors/storage-error.ts 84 100 84.0%
Totals Coverage Status
Change from base Build 9644028748: 0.1%
Covered Lines: 12772
Relevant Lines: 15802

💛 - Coveralls

Copy link
Member

@inian inian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming the refactor commit was done in an automated way, other ones lgtm

@fenos fenos merged commit 6dda887 into master Jun 25, 2024
1 check passed
@fenos fenos deleted the chore/improvements branch June 25, 2024 14:00
Copy link

🎉 This PR is included in version 1.6.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants