fix: run migrations after tenant creation #506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fenos
force-pushed
the
fix/run-migrations-after-tenant-creation
branch
from
0429dfe to
3c50325
Compare
Pull Request Test Coverage Report for Build 9613107917Details
💛 - Coveralls |
fenos
force-pushed
the
fix/run-migrations-after-tenant-creation
branch
from
3c50325 to
089daf1
Compare
Pull Request Test Coverage Report for Build 9613241131Details
💛 - Coveralls |
fenos
force-pushed
the
fix/run-migrations-after-tenant-creation
branch
from
089daf1 to
57460bf
Compare
Pull Request Test Coverage Report for Build 9614873221Details
💛 - Coveralls |
inian
approved these changes
Jun 24, 2024
|
🎉 This PR is included in version 1.6.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
When a tenant is being created, we first try to run the migrations and then register the target.
This sometimes causes the tenant to never be added if the database is not currently reachable
What is the new behavior?
Migrations are now run after the tenant creation.
If an error occur during the migrations, we schedule a job to re-run async with a queue job