Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: s3 delete objects improve validation #505

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

fenos
Copy link
Contributor

@fenos fenos commented Jun 20, 2024

What kind of change does this PR introduce?

Bug fix

What is the new behavior?

DeleteObjectCommand Enforces Delete.Object to be an array

closes #504

@coveralls
Copy link

coveralls commented Jun 20, 2024

Pull Request Test Coverage Report for Build 9593693365

Details

  • 19 of 25 (76.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.04%) to 80.048%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/storage/protocols/s3/s3-handler.ts 15 16 93.75%
src/storage/errors.ts 4 9 44.44%
Files with Coverage Reduction New Missed Lines %
src/storage/protocols/s3/s3-handler.ts 1 84.07%
Totals Coverage Status
Change from base Build 9497160408: 0.04%
Covered Lines: 12631
Relevant Lines: 15635

💛 - Coveralls

@fenos fenos force-pushed the s3/delete-objects-array-validation branch from ac6b230 to d53138a Compare June 20, 2024 10:23
@coveralls
Copy link

coveralls commented Jun 20, 2024

Pull Request Test Coverage Report for Build 9595795540

Details

  • 73 of 83 (87.95%) changed or added relevant lines in 5 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.08%) to 80.091%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/storage/protocols/s3/s3-handler.ts 15 16 93.75%
src/http/routes/s3/router.ts 41 45 91.11%
src/storage/errors.ts 4 9 44.44%
Files with Coverage Reduction New Missed Lines %
src/storage/protocols/s3/s3-handler.ts 1 84.07%
Totals Coverage Status
Change from base Build 9497160408: 0.08%
Covered Lines: 12680
Relevant Lines: 15688

💛 - Coveralls

@fenos fenos merged commit c715a7b into master Jun 20, 2024
1 check passed
@fenos fenos deleted the s3/delete-objects-array-validation branch June 20, 2024 15:07
Copy link

🎉 This PR is included in version 1.5.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete.Objects.map is not a function when trying to delete a single file via S3 DeleteObjects Command
3 participants