Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: s3 Signed URLs #500

Merged
merged 1 commit into from
Jun 12, 2024
Merged

feat: s3 Signed URLs #500

merged 1 commit into from
Jun 12, 2024

Conversation

fenos
Copy link
Contributor

@fenos fenos commented Jun 12, 2024

What kind of change does this PR introduce?

Feature

What is the current behavior?

S3 Signed URLs were not supported

What is the new behavior?

S3 Signed URLs are now supported

Closes #465

@coveralls
Copy link

coveralls commented Jun 12, 2024

Pull Request Test Coverage Report for Build 9482514517

Details

  • 153 of 185 (82.7%) changed or added relevant lines in 6 files are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.04%) to 79.897%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/storage/errors.ts 1 3 33.33%
src/http/plugins/signature-v4.ts 20 26 76.92%
src/storage/protocols/s3/signature-v4.ts 110 134 82.09%
Files with Coverage Reduction New Missed Lines %
src/storage/protocols/s3/signature-v4.ts 1 79.24%
src/http/plugins/log-request.ts 4 90.84%
Totals Coverage Status
Change from base Build 9463601755: -0.04%
Covered Lines: 12621
Relevant Lines: 15642

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 12, 2024

Pull Request Test Coverage Report for Build 9482545325

Details

  • 153 of 185 (82.7%) changed or added relevant lines in 6 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 79.909%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/storage/errors.ts 1 3 33.33%
src/http/plugins/signature-v4.ts 20 26 76.92%
src/storage/protocols/s3/signature-v4.ts 110 134 82.09%
Files with Coverage Reduction New Missed Lines %
src/storage/protocols/s3/signature-v4.ts 1 79.24%
Totals Coverage Status
Change from base Build 9463601755: -0.03%
Covered Lines: 12631
Relevant Lines: 15652

💛 - Coveralls

@fenos fenos merged commit 6ec58e2 into master Jun 12, 2024
1 check passed
@fenos fenos deleted the s3/signed-urls branch June 12, 2024 12:58
Copy link

🎉 This PR is included in version 1.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@coveralls
Copy link

coveralls commented Jun 12, 2024

Pull Request Test Coverage Report for Build 9482937024

Details

  • 157 of 185 (84.86%) changed or added relevant lines in 6 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.03%) to 79.964%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/http/plugins/signature-v4.ts 20 26 76.92%
src/storage/protocols/s3/signature-v4.ts 112 134 83.58%
Files with Coverage Reduction New Missed Lines %
src/storage/protocols/s3/signature-v4.ts 1 80.0%
Totals Coverage Status
Change from base Build 9463601755: 0.03%
Covered Lines: 12638
Relevant Lines: 15652

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 12, 2024

Pull Request Test Coverage Report for Build 9482958449

Details

  • 157 of 185 (84.86%) changed or added relevant lines in 6 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.03%) to 79.964%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/http/plugins/signature-v4.ts 20 26 76.92%
src/storage/protocols/s3/signature-v4.ts 112 134 83.58%
Files with Coverage Reduction New Missed Lines %
src/storage/protocols/s3/signature-v4.ts 1 80.0%
Totals Coverage Status
Change from base Build 9463601755: 0.03%
Covered Lines: 12638
Relevant Lines: 15652

💛 - Coveralls

@michaeljauk
Copy link

Just stumbled upon this PR as this is something that we would currently need within our environment 👀
What's usually the ETA for a feature being merged until it becomes publicly available?

@fenos
Copy link
Contributor Author

fenos commented Jun 12, 2024

Will likely be released this or next week 👍🏻

@fenos
Copy link
Contributor Author

fenos commented Jun 19, 2024

@michaeljauk this has now being released GA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

S3 Upload with presigned URL
4 participants