Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix s3 file driver xattr #453

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Fix s3 file driver xattr #453

merged 1 commit into from
Apr 15, 2024

Conversation

fenos
Copy link
Contributor

@fenos fenos commented Apr 15, 2024

What kind of change does this PR introduce?

Bug fix

What is the new behavior?

  • removed @types/ajv since they are shipped with the lib
  • disable bodyParser for PutObject requests (improves performance)
  • fix xattr metadata for s3 multi-part upload
  • fix equality check for copying objects across buckets

@coveralls
Copy link

coveralls commented Apr 15, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8686883671

Details

  • 113 of 119 (94.96%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.07%) to 79.421%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/http/routes/s3/index.ts 35 37 94.59%
src/storage/backend/file.ts 2 6 33.33%
Totals Coverage Status
Change from base Build 8672759026: 0.07%
Covered Lines: 11832
Relevant Lines: 14763
💛 - Coveralls

@fenos fenos force-pushed the s3-protocol/fix-file-driver branch 2 times, most recently from 8023a42 to 9c90daa Compare April 15, 2024 09:34
@fenos fenos force-pushed the s3-protocol/fix-file-driver branch from 9c90daa to 498be0d Compare April 15, 2024 09:38
sweatybridge
sweatybridge approved these changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@sweatybridge sweatybridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if my +1 counts

@fenos fenos merged commit ef43f25 into master Apr 15, 2024
1 check passed
@fenos fenos deleted the s3-protocol/fix-file-driver branch April 15, 2024 09:49
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 1.0.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inian inian inian approved these changes

@sweatybridge sweatybridge sweatybridge approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fenos @coveralls @sweatybridge @inian