Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exclude empty headers on S3 protocol #451

Merged
merged 1 commit into from
Apr 13, 2024

Conversation

fenos
Copy link
Contributor

@fenos fenos commented Apr 13, 2024

What kind of change does this PR introduce?

Bug fix

What is the current behavior?

Some S3 Clients tries to parse headers if returned as empty causing issues.

What is the new behavior?

Empty headers are not returned

@fenos fenos merged commit b9b9ab0 into master Apr 13, 2024
1 check passed
@fenos fenos deleted the fix/exclude-empty-headers-s3 branch April 13, 2024 10:07
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8672733831

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 79.354%

Totals Coverage Status
Change from base Build 8672629210: 0.002%
Covered Lines: 11773
Relevant Lines: 14701

💛 - Coveralls

Copy link

🎉 This PR is included in version 1.0.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants