Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: db install roles default env to false #428

Merged
merged 1 commit into from
Jan 25, 2024
Merged

fix: db install roles default env to false #428

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@ jobs:
GLOBAL_S3_ENDPOINT: http://127.0.0.1:9000
GLOBAL_S3_PROTOCOL: http
GLOBAL_S3_FORCE_PATH_STYLE: true
DB_INSTALL_ROLES: true

- name: Upload coverage results to Coveralls
uses: coverallsapp/github-action@master
Expand Down
2 changes: 1 addition & 1 deletion src/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,7 @@ export function getConfig(options?: { reload?: boolean }): StorageConfigType {
dbAnonRole: getOptionalConfigFromEnv('DB_ANON_ROLE') || 'anon',
dbServiceRole: getOptionalConfigFromEnv('DB_SERVICE_ROLE') || 'service_role',
dbAuthenticatedRole: getOptionalConfigFromEnv('DB_AUTHENTICATED_ROLE') || 'authenticated',
dbInstallRoles: !(getOptionalConfigFromEnv('DB_INSTALL_ROLES') === 'false'),
dbInstallRoles: getOptionalConfigFromEnv('DB_INSTALL_ROLES') === 'true',
dbRefreshMigrationHashesOnMismatch: !(
getOptionalConfigFromEnv('DB_ALLOW_MIGRATION_REFRESH') === 'false'
),
Expand Down
Loading