Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: content-type charset #415

Merged
merged 1 commit into from
Jan 11, 2024
Merged

fix: content-type charset #415

merged 1 commit into from
Jan 11, 2024

Conversation

fenos
Copy link
Contributor

@fenos fenos commented Jan 10, 2024

What kind of change does this PR introduce?

Bug fix

What is the current behavior?

When explicitly passing contentType: text/vtt;charset=utf-8 the charset is not retained in the response

What is the new behavior?

honor the content type provided in the form data

Additional context

Fixes #366

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7475805294

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 82.82%

Totals Coverage Status
Change from base Build 7459041197: -0.02%
Covered Lines: 7750
Relevant Lines: 9250

💛 - Coveralls

@fenos fenos merged commit 9b1f22b into master Jan 11, 2024
1 check passed
@fenos fenos deleted the fix/content-type-charset branch January 11, 2024 10:31
Copy link

🎉 This PR is included in version 0.44.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Charset is ommitted when setting contentType attribute during uploads
3 participants