fix: base64 encode for metadata in headers

supabase · Jul 11, 2024 · 01402bd · 01402bd
1 parent d0f0348
commit 01402bd
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 55 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -29,7 +29,7 @@
     "@aws-sdk/lib-storage": "3.515.0",
     "@aws-sdk/s3-request-presigner": "3.421.0",
     "@fastify/accepts": "^4.3.0",
-    "@fastify/multipart": "^7.6.0",
+    "@fastify/multipart": "^8.3.0",
     "@fastify/rate-limit": "^7.6.0",
     "@fastify/swagger": "^8.3.1",
     "@fastify/swagger-ui": "^1.7.0",

diff --git a/src/storage/uploader.ts b/src/storage/uploader.ts
@@ -326,12 +326,9 @@ export class Uploader {
       const customMd = request.headers['x-metadata']
 
       if (typeof customMd === 'string') {
-        if (userMetadata && Buffer.byteLength(customMd, 'utf8') > MAX_CUSTOM_METADATA_SIZE) {
-          throw ERRORS.EntityTooLarge(undefined, 'metadata')
-        }
-
         try {
-          userMetadata = JSON.parse(customMd)
+          const json = Buffer.from(customMd, 'base64').toString('utf8')
+          userMetadata = JSON.parse(json)
         } catch (e) {
           // no-op
         }