Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade pg_net and allow greater user-control over its parameters #1069

Merged
merged 4 commits into from
Aug 28, 2024

Conversation

TheOtherBrian1
Copy link
Contributor

@TheOtherBrian1 TheOtherBrian1 commented Jul 23, 2024

What kind of change does this PR introduce?

Modified supautils configs

What is the current behavior?

pg_net variables and the log_lock_waits variable cannot be configured by users.

What is the new behavior?

Allows users to configure pg_net variables (other than database):

  • pg_net.ttl
  • pg_net.batch_size

Gives users permission to log locks that last for more than 1s

  • log_lock_waits

Additional context

Add any other context or screenshots.

@TheOtherBrian1 TheOtherBrian1 requested a review from a team as a code owner July 23, 2024 19:56
@TheOtherBrian1 TheOtherBrian1 requested a review from soedirgo July 25, 2024 21:15
@TheOtherBrian1 TheOtherBrian1 enabled auto-merge (squash) July 29, 2024 07:42
Copy link
Member

@steve-chavez steve-chavez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@steve-chavez
Copy link
Member

Hm, wait. Is this config applicable now that we use the Nix build?

@olirice
Copy link
Contributor

olirice commented Aug 14, 2024

@samrose It doesn't look like the settings in supautils.conf are being applied (maybe only a local thing) but

postgres=# set pg_net.ttl = '1s'
ERROR:  parameter "pg_net.ttl" cannot be changed now
  • is that the correct location for supautils config?
  • does it apply locally?

@samrose
Copy link
Contributor

samrose commented Aug 14, 2024

@samrose It doesn't look like the settings in supautils.conf are being applied (maybe only a local thing) but

postgres=# set pg_net.ttl = '1s'
ERROR:  parameter "pg_net.ttl" cannot be changed now
  • is that the correct location for supautils config?
  • does it apply locally?

I think you are right that those settings have not been wired in yet on local testing

I’ll be back in front of computer in a few and will get it working in local testing context

@samrose
Copy link
Contributor

samrose commented Aug 22, 2024

We did recently merge in a pr to develop that correctly used all of our configurations and migrations

#1130

@soedirgo soedirgo force-pushed the TheOtherBrian1-patch-1 branch from 60be729 to d8c6c41 Compare August 22, 2024 11:55
Copy link
Member

@soedirgo soedirgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on staging

@soedirgo
Copy link
Member

cc @supabase/backend for a +1

@TheOtherBrian1 TheOtherBrian1 merged commit f9cee1e into develop Aug 28, 2024
8 checks passed
@TheOtherBrian1 TheOtherBrian1 deleted the TheOtherBrian1-patch-1 branch August 28, 2024 05:50
@darora darora changed the title Update supautils.conf.j2 | exempted net and logging variables Upgrade pg_net and allow greater user-control over its parameters Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants