-
-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade pg_net and allow greater user-control over its parameters #1069
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hm, wait. Is this config applicable now that we use the Nix build? |
@samrose It doesn't look like the settings in supautils.conf are being applied (maybe only a local thing) but
|
I think you are right that those settings have not been wired in yet on local testing I’ll be back in front of computer in a few and will get it working in local testing context |
We did recently merge in a pr to develop that correctly used all of our configurations and migrations |
60be729
to
d8c6c41
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on staging
cc @supabase/backend for a +1 |
What kind of change does this PR introduce?
Modified supautils configs
What is the current behavior?
pg_net variables and the log_lock_waits variable cannot be configured by users.
What is the new behavior?
Allows users to configure pg_net variables (other than database):
Gives users permission to log locks that last for more than 1s
Additional context
Add any other context or screenshots.