fix: unmarshal remote override into base config #3028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sweatybridge
force-pushed
the
unmarshal-remote
branch
2 times, most recently
from
b273304 to
b796074
Compare
sweatybridge
force-pushed
the
unmarshal-remote
branch
4 times, most recently
from
83b3506 to
5443781
Compare
sweatybridge
force-pushed
the
unmarshal-remote
branch
from
5443781 to
dc45095
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
What is the new behavior?
Instead of copying base config to each remote, we now merge the remote override directly to base config. This simplifies parsing and also makes accessing utils.Config more consistent in cli.
Additional context
Add any other context or screenshots.