Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dump): print complete filedist path for dump #2968

Merged
merged 4 commits into from
Dec 11, 2024
Merged

feat(dump): print complete filedist path for dump #2968

merged 4 commits into from
Dec 11, 2024

Conversation

avallete
Copy link
Member

What kind of change does this PR introduce?

  • Show the absolute path when dump commande is directed to a file

@avallete avallete requested a review from a team as a code owner December 11, 2024 14:22
@avallete avallete changed the title choredump): print complete filedist path for dump feat(dump): print complete filedist path for dump Dec 11, 2024
@coveralls
Copy link

coveralls commented Dec 11, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12281518251

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 7 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.007%) to 59.721%
Files with Coverage Reduction New Missed Lines %
internal/storage/rm/rm.go 2 89.53%
internal/gen/keys/keys.go 5 12.9%
Totals Coverage Status
Change from base Build 12279002092: -0.007%
Covered Lines: 7652
Relevant Lines: 12813
💛 - Coveralls

sweatybridge
sweatybridge approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@sweatybridge sweatybridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a nitpick

cmd/db.go Outdated Show resolved Hide resolved
@avallete avallete enabled auto-merge (squash) December 11, 2024 17:18
@avallete avallete merged commit e0d03ec into develop Dec 11, 2024
8 checks passed
@avallete avallete deleted the chore/print-dump-result-full-path branch December 11, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sweatybridge sweatybridge sweatybridge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@avallete @coveralls @sweatybridge