Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable image transformation and mfa by default #2966

Merged
merged 6 commits into from
Dec 11, 2024
Merged

Conversation

sweatybridge
Copy link
Contributor

@sweatybridge sweatybridge commented Dec 11, 2024

What kind of change does this PR introduce?

Bug fix

What is the new behavior?

To make config push work out of the box for free projects, stop enabling paid features locally by default.

Additional context

Add any other context or screenshots.

@sweatybridge sweatybridge requested a review from a team as a code owner December 11, 2024 09:08
@coveralls
Copy link

coveralls commented Dec 11, 2024

Pull Request Test Coverage Report for Build 12273582308

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 35 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.3%) to 59.683%

Files with Coverage Reduction New Missed Lines %
internal/gen/keys/keys.go 5 12.9%
internal/start/start.go 30 66.45%
Totals Coverage Status
Change from base Build 12271544593: -0.3%
Covered Lines: 7640
Relevant Lines: 12801

💛 - Coveralls

@sweatybridge sweatybridge changed the title fix: disable image transformation by default fix: disable image transformation and mfa by default Dec 11, 2024
@avallete
Copy link
Member

avallete commented Dec 11, 2024

Sorry didn't noticed. But shouldn't we also update the default value here @sweatybridge : https://github.com/supabase/cli/blob/fix/update-free-tier-projects/pkg/config/config.go#L321-L324

If the value is not explicit in the config (left undefined).

@sweatybridge
Copy link
Contributor Author

@avallete good catch. I've removed the default value.

@sweatybridge sweatybridge merged commit 8cac0be into develop Dec 11, 2024
9 checks passed
@sweatybridge sweatybridge deleted the disable-it branch December 11, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants