Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: enforce auth hook secrets conform to standard webhooks #2961

Merged
merged 4 commits into from
Dec 10, 2024
Merged

fix: enforce auth hook secrets conform to standard webhooks #2961

merged 4 commits into from
Dec 10, 2024

Conversation

sweatybridge
Copy link
Contributor

@sweatybridge sweatybridge commented Dec 10, 2024 •
edited
Loading

What kind of change does this PR introduce?

Bug fix

What is the new behavior?

  • More thorough hook secrets validation before calling API
  • Use platform default when hook is unset in config.toml
  • Stop hashing empty string as platform never returns them

Additional context

Add any other context or screenshots.

@sweatybridge sweatybridge merged commit 8935766 into develop Dec 10, 2024
9 checks passed
@sweatybridge sweatybridge deleted the omit-secret branch December 10, 2024 10:26
@sweatybridge sweatybridge mentioned this pull request Dec 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sweatybridge