Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: optional smtp block should not override remote #2954

Merged
merged 1 commit into from
Dec 7, 2024
Merged

Conversation

sweatybridge
Copy link
Contributor

@sweatybridge sweatybridge commented Dec 7, 2024

What kind of change does this PR introduce?

Bug fix

What is the new behavior?

If [auth.email.smtp] is not declared in config.toml, skip pushing the config to remote.

Also adds a enabled field to allow explicit disabling of smtp.

Additional context

Add any other context or screenshots.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12215182885

Details

  • 28 of 41 (68.29%) changed or added relevant lines in 3 files are covered.
  • 8 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.07%) to 59.903%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/config/auth.go 26 39 66.67%
Files with Coverage Reduction New Missed Lines %
internal/debug/postgres.go 3 64.86%
internal/gen/keys/keys.go 5 12.9%
Totals Coverage Status
Change from base Build 12214394323: -0.07%
Covered Lines: 7658
Relevant Lines: 12784

💛 - Coveralls

@sweatybridge sweatybridge merged commit ac76d14 into develop Dec 7, 2024
9 checks passed
@sweatybridge sweatybridge deleted the smtp-diff branch December 7, 2024 19:41
@github-actions github-actions bot mentioned this pull request Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants