Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: account for remote config when pushing #2952

Merged
merged 3 commits into from
Dec 7, 2024
Merged

Conversation

sweatybridge
Copy link
Contributor

@sweatybridge sweatybridge commented Dec 7, 2024

What kind of change does this PR introduce?

Bug fix

What is the new behavior?

Updates functions, storage, reset, and typegen to account for remote config.

Additional context

Add any other context or screenshots.

@coveralls
Copy link

coveralls commented Dec 7, 2024

Pull Request Test Coverage Report for Build 12212441409

Details

  • 38 of 58 (65.52%) changed or added relevant lines in 10 files are covered.
  • 6 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.003%) to 59.644%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/services/services.go 0 1 0.0%
internal/utils/flags/project_ref.go 14 15 93.33%
internal/start/start.go 0 3 0.0%
internal/utils/flags/db_url.go 0 6 0.0%
internal/db/reset/reset.go 11 20 55.0%
Files with Coverage Reduction New Missed Lines %
internal/utils/flags/project_ref.go 1 84.78%
internal/gen/keys/keys.go 5 12.9%
Totals Coverage Status
Change from base Build 12211443224: -0.003%
Covered Lines: 6404
Relevant Lines: 10737

💛 - Coveralls

@sweatybridge sweatybridge changed the title chore: skip loading project ref if flag is set fix: account for remote config when pushing Dec 7, 2024
@sweatybridge sweatybridge marked this pull request as ready for review December 7, 2024 10:40
@sweatybridge sweatybridge merged commit 4a7e73e into develop Dec 7, 2024
9 checks passed
@sweatybridge sweatybridge deleted the project-config branch December 7, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants