fix: skip pushing site url config for localhost #2949
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 12199599714Details
💛 - Coveralls |
sweatybridge
force-pushed
the
skip-site-url
branch
from
f13c519 to
2476860
Compare
avallete
reviewed
Dec 6, 2024
Comment on lines
+222
to
+229
| func isLoopbackURL(siteURL string) bool { | ||
| if parsed, err := url.Parse(siteURL); err == nil { | ||
| if ip := net.ParseIP(parsed.Hostname()); ip != nil { | ||
| return ip.IsLoopback() | ||
| } | ||
| } | ||
| return false | ||
| } |
There was a problem hiding this comment.
nitpick
Wonder if it might cause issue if you use local aliase like localhost.
But that'll probably work for most of the setup.
|
Closing as probably not needed after we start pushing down envs from vercel. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
relates to #2552 (comment)
What is the new behavior?
Skip site_url if it's pointing to localhost.
Additional context
Add any other context or screenshots.