Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): add api config for branching override #2761

Merged
merged 24 commits into from
Oct 16, 2024

Conversation

avallete
Copy link
Member

What kind of change does this PR introduce?

Feature add tooling around api config to be used inside branching for config override.

What is the current behavior?

Please link any relevant issues here.

What is the new behavior?

Feel free to include screenshots if it includes visual changes.

Additional context

Add any other context or screenshots.

internal/utils/diff/diff.go Outdated Show resolved Hide resolved
pkg/config/api.go Outdated Show resolved Hide resolved
pkg/config/api.go Outdated Show resolved Hide resolved
pkg/config/config.go Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Oct 12, 2024

Pull Request Test Coverage Report for Build 11361557438

Details

  • 6 of 10 (60.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.5%) to 59.692%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/link/link.go 6 10 60.0%
Totals Coverage Status
Change from base Build 11356607401: -0.5%
Covered Lines: 6356
Relevant Lines: 10648

💛 - Coveralls

@avallete avallete marked this pull request as ready for review October 14, 2024 13:58
@avallete avallete requested a review from sweatybridge October 14, 2024 13:58
internal/utils/cast/cast.go Outdated Show resolved Hide resolved
pkg/config/api.go Outdated Show resolved Hide resolved
pkg/config/config.go Outdated Show resolved Hide resolved
pkg/config/api.go Outdated Show resolved Hide resolved
pkg/config/api.go Outdated Show resolved Hide resolved
pkg/config/config.go Outdated Show resolved Hide resolved
pkg/config/config.go Outdated Show resolved Hide resolved
pkg/config/config.go Outdated Show resolved Hide resolved
pkg/config/config.go Outdated Show resolved Hide resolved
@avallete avallete merged commit c7bdbc2 into develop Oct 16, 2024
9 checks passed
@avallete avallete deleted the avallete/feat-add-api-config-remote-tooling branch October 16, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants