Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: check project status at link time #2730

Merged
merged 8 commits into from
Oct 8, 2024

Conversation

avallete
Copy link
Member

@avallete avallete commented Oct 4, 2024

What kind of change does this PR introduce?

Following: https://github.com/supabase/infrastructure/pull/20022

We check the status of the project at link time and provide better error and warning message to the user.

Goal is to reduce confusion when errors raise in CI in such cases

What is the current behavior?

Please link any relevant issues here.

What is the new behavior?

Feel free to include screenshots if it includes visual changes.

Additional context

Related: https://github.com/supabase/infrastructure/pull/20117

@avallete avallete requested a review from a team as a code owner October 4, 2024 22:15
@coveralls
Copy link

coveralls commented Oct 5, 2024

Pull Request Test Coverage Report for Build 11232571830

Details

  • 15 of 22 (68.18%) changed or added relevant lines in 1 file are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 60.216%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/link/link.go 15 22 68.18%
Files with Coverage Reduction New Missed Lines %
internal/gen/keys/keys.go 5 12.9%
Totals Coverage Status
Change from base Build 11230896950: 0.1%
Covered Lines: 6513
Relevant Lines: 10816

💛 - Coveralls

internal/link/link.go Outdated Show resolved Hide resolved
internal/link/link.go Outdated Show resolved Hide resolved
Copy link

resume project from cli

@avallete avallete requested a review from sweatybridge October 7, 2024 08:48
@avallete avallete merged commit ce26abd into develop Oct 8, 2024
13 checks passed
@avallete avallete deleted the avallete/feat-link-paused-projects-error branch October 8, 2024 10:37
@github-actions github-actions bot mentioned this pull request Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants