chore: start command validate exclude arguments #2697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When providing --exclude flags, check the arguments match actuals images names show a warning otherwise. Also fix a bug where stack couldnt start if storage was enabled in config but excluded in the arguments Related: https://www.notion.so/supabase/exclude-doesnt-seem-to-work-f38b8444b62f4308aef657a52d51692b
Pull Request Test Coverage Report for Build 10960007617Details
💛 - Coveralls |
sweatybridge
approved these changes
Sep 20, 2024
Co-authored-by: Han Qiao <[email protected]>
avallete
deleted the
avallete/chore-start-command-validate-exclude-names
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
When providing --exclude flags, check the arguments match actuals images names show a warning otherwise.
Also fix a bug where stack couldnt start if storage was enabled in config but excluded in the arguments
Related: https://www.notion.so/supabase/exclude-doesnt-seem-to-work-f38b8444b62f4308aef657a52d51692b
What is the current behavior?
Please link any relevant issues here.
What is the new behavior?
Additional context
Also might be worth considering allowing to alias between config services names and "containers exclusions" names. As it's not clear for instance that "gotrue" container relate to the "auth" service.