Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support custom docker network id #2362

Merged
merged 1 commit into from
Jun 4, 2024
Merged

feat: support custom docker network id #2362

merged 1 commit into from
Jun 4, 2024

Conversation

sweatybridge
Copy link
Contributor

@sweatybridge sweatybridge commented Jun 3, 2024 •
edited
Loading

What kind of change does this PR introduce?

closes #2358
supersedes: #1581

What is the new behavior?

supabase start --network-id test-network

or

SUPABASE_NETWORK_ID=test-network supabase test db --db-url <conn-string>

Additional context

Add any other context or screenshots.

@sweatybridge sweatybridge requested a review from a team as a code owner June 3, 2024 09:38
@coveralls
Copy link

coveralls commented Jun 3, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9366513771

Details

  • 17 of 18 (94.44%) changed or added relevant lines in 7 files are covered.
  • 6 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.02%) to 60.054%
Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/utils/docker.go 3 4 75.0%
Files with Coverage Reduction New Missed Lines %
internal/utils/console.go 1 90.16%
internal/gen/keys/keys.go 5 11.76%
Totals Coverage Status
Change from base Build 9362515422: -0.02%
Covered Lines: 6896
Relevant Lines: 11483
💛 - Coveralls

@sweatybridge sweatybridge force-pushed the use-host branch 2 times, most recently from 5db7179 to dcc4131 Compare June 4, 2024 11:35
@sweatybridge sweatybridge changed the title fix: use host network only when connecting to daemon host feat: support custom docker network id Jun 4, 2024
@sweatybridge sweatybridge merged commit e8aaf93 into develop Jun 4, 2024
9 checks passed
@sweatybridge sweatybridge deleted the use-host branch June 4, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test db --db-url fails in Bitbucket Pipelines
2 participants
@sweatybridge @coveralls