Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fetch start command for bootstrap from samples.json #2130

Closed
wants to merge 5 commits into from

Conversation

J0
Copy link
Contributor

@J0 J0 commented Apr 6, 2024

What kind of change does this PR introduce?

Currently, we use a hardcoded start command (e.g. npm run dev) which might not generalize to non-javascript projects. This PR aims to fix this by fetching from samples.json

Copy link

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8584240972

Details

  • 10 of 12 (83.33%) changed or added relevant lines in 1 file are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 57.828%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/bootstrap/bootstrap.go 10 12 83.33%
Files with Coverage Reduction New Missed Lines %
internal/gen/keys/keys.go 5 11.76%
Totals Coverage Status
Change from base Build 8574460707: 0.0%
Covered Lines: 6386
Relevant Lines: 11043

💛 - Coveralls

@J0
Copy link
Contributor Author

J0 commented Apr 8, 2024

Switch to pass down Start from top level command instead.

@sweatybridge sweatybridge deleted the j0/fetch_bootstrap_start_from_samples_json branch November 13, 2024 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants