Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add template_url param to bootstrap #2120

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

hf
Copy link
Contributor

@hf hf commented Apr 4, 2024

Adds the template_url value when the bootstrap command is executed, for tracking which template was used to create a project.

I've manually edited the OpenAPI file, as it appears the latest platform generated OpenAPI renames CreateProjectBody to V1CreateProjectBody.

Do not merge until the API is deployed.

@hf hf requested a review from a team as a code owner April 4, 2024 16:39
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8558203996

Details

  • 0 of 4 (0.0%) changed or added relevant lines in 1 file are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.04%) to 57.809%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/bootstrap/bootstrap.go 0 4 0.0%
Files with Coverage Reduction New Missed Lines %
internal/gen/keys/keys.go 5 11.76%
Totals Coverage Status
Change from base Build 8551064524: -0.04%
Covered Lines: 6374
Relevant Lines: 11026

💛 - Coveralls

@sweatybridge sweatybridge merged commit f53149f into develop Apr 9, 2024
13 checks passed
@sweatybridge sweatybridge deleted the hf/add-template-url-to-bootstrap branch April 9, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants