Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable keyring on WSL1 #2112

Merged
merged 1 commit into from
Apr 2, 2024
Merged

fix: disable keyring on WSL1 #2112

merged 1 commit into from
Apr 2, 2024

Conversation

sweatybridge
Copy link
Contributor

@sweatybridge sweatybridge commented Apr 2, 2024

What kind of change does this PR introduce?

Bug fix #1509 (comment)

What is the new behavior?

Check for string either WSL or Microsoft.

Additional context

Add any other context or screenshots.

@sweatybridge sweatybridge requested a review from a team as a code owner April 2, 2024 06:04
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8518177272

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 2 of 4 (50.0%) changed or added relevant lines in 1 file are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 57.809%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/utils/credentials/store.go 2 4 50.0%
Files with Coverage Reduction New Missed Lines %
internal/gen/keys/keys.go 5 11.76%
Totals Coverage Status
Change from base Build 8518174600: -0.02%
Covered Lines: 6370
Relevant Lines: 11019

💛 - Coveralls

@sweatybridge sweatybridge merged commit 57f4d51 into develop Apr 2, 2024
9 checks passed
@sweatybridge sweatybridge deleted the fix-wsl1 branch April 2, 2024 06:23
@minism
Copy link

minism commented Apr 3, 2024

Thanks for the quick fix! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants