Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check project health on bootstrap #2109

Merged
merged 1 commit into from
Apr 1, 2024
Merged

Conversation

sweatybridge
Copy link
Contributor

@sweatybridge sweatybridge commented Apr 1, 2024

What kind of change does this PR introduce?

Bug fix

What is the current behavior?

Bootstrap project may timeout waiting to become active healthy.

What is the new behavior?

Sepearate database and pooler status checks so that bootstrap is more robust against timeouts.

Linking project...
Retry (1/8): Linking project...
Checking project health...
Retry (1/8): Checking project health...
Retry (2/8): Checking project health...
Retry (3/8): Checking project health...
Retry (4/8): Checking project health...
Retry (5/8): Checking project health...
Connecting to remote database...
Retry (1/8): Connecting to remote database...
Retry (2/8): Connecting to remote database...
Retry (3/8): Connecting to remote database...
Retry (4/8): Connecting to remote database...
Retry (5/8): Connecting to remote database...
Retry (6/8): Connecting to remote database...
Remote database is up to date.
To start your app:
  cd empty
  npm ci
  npm run dev

Additional context

Add any other context or screenshots.

@sweatybridge sweatybridge requested a review from a team as a code owner April 1, 2024 06:40
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8504869493

Details

  • 0 of 25 (0.0%) changed or added relevant lines in 1 file are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 57.805%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/bootstrap/bootstrap.go 0 25 0.0%
Files with Coverage Reduction New Missed Lines %
internal/gen/keys/keys.go 5 11.76%
Totals Coverage Status
Change from base Build 8504848623: -0.2%
Covered Lines: 6369
Relevant Lines: 11018

💛 - Coveralls

@sweatybridge sweatybridge merged commit b04799b into develop Apr 1, 2024
13 checks passed
@sweatybridge sweatybridge deleted the health-check branch April 1, 2024 06:53
@github-actions github-actions bot mentioned this pull request Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants