Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reuse common login flows #2098

Merged
merged 2 commits into from
Mar 27, 2024
Merged

fix: reuse common login flows #2098

merged 2 commits into from
Mar 27, 2024

Conversation

sweatybridge
Copy link
Contributor

@sweatybridge sweatybridge commented Mar 27, 2024

What kind of change does this PR introduce?

Bug fix #1054

What is the new behavior?

Order of token parsing should be flag > env > stdin.

Additional context

Add any other context or screenshots.

@sweatybridge sweatybridge requested a review from a team as a code owner March 27, 2024 08:01
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8448434690

Details

  • 24 of 58 (41.38%) changed or added relevant lines in 4 files are covered.
  • 15 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.1%) to 57.474%

Changes Missing Coverage Covered Lines Changed/Added Lines %
cmd/login.go 4 5 80.0%
internal/bootstrap/bootstrap.go 0 4 0.0%
internal/login/login.go 8 37 21.62%
Files with Coverage Reduction New Missed Lines %
cmd/login.go 3 68.42%
internal/gen/keys/keys.go 5 11.76%
internal/login/login.go 7 27.38%
Totals Coverage Status
Change from base Build 8447285636: -0.1%
Covered Lines: 6290
Relevant Lines: 10944

💛 - Coveralls

@sweatybridge sweatybridge merged commit dbe2bcf into develop Mar 27, 2024
9 checks passed
@sweatybridge sweatybridge deleted the tidy-login branch March 27, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot type in Access Token in cmd or powershell
2 participants