Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storage): resolve relative path from cwd #2094

Merged
merged 1 commit into from
Mar 26, 2024
Merged

fix(storage): resolve relative path from cwd #2094

merged 1 commit into from
Mar 26, 2024

Conversation

sweatybridge
Copy link
Contributor

@sweatybridge sweatybridge commented Mar 26, 2024

What kind of change does this PR introduce?

Bug fix

What is the current behavior?

supabase storage cp --workdir /tmp ss:///test . downloads files to /tmp instead of the current directory.

What is the new behavior?

Respect the relative path passed in from cli arg.

Additional context

Add any other context or screenshots.

@sweatybridge sweatybridge requested a review from a team as a code owner March 26, 2024 08:17
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8432817504

Details

  • 11 of 11 (100.0%) changed or added relevant lines in 1 file are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.004%) to 57.549%

Files with Coverage Reduction New Missed Lines %
internal/gen/keys/keys.go 5 11.76%
Totals Coverage Status
Change from base Build 8432603760: 0.004%
Covered Lines: 6316
Relevant Lines: 10975

💛 - Coveralls

@sweatybridge sweatybridge merged commit d98aab5 into develop Mar 26, 2024
9 checks passed
@sweatybridge sweatybridge deleted the fix-cp branch March 26, 2024 08:24
@github-actions github-actions bot mentioned this pull request Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants