Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add auth hooks config #1856

Merged
merged 7 commits into from
Jan 19, 2024
Merged

feat: add auth hooks config #1856

merged 7 commits into from
Jan 19, 2024

Conversation

J0
Copy link
Contributor

@J0 J0 commented Jan 17, 2024

What kind of change does this PR introduce?

Add configuration for auth hooks so that developers can test their hooks locally. Key fields for each hook are:

Enabled - true/false
URI - this should be in the form pg-functions://<database>/<schema>/<function-name>

This was tested by locally building the cli go build . and then ../cli/init + ../cli/start. Check that Docker has GOTRUE_HOOK_<HOOK_NAME>_ENABLED

@coveralls
Copy link

coveralls commented Jan 17, 2024

Pull Request Test Coverage Report for Build 7580861705

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 58.661%

Totals Coverage Status
Change from base Build 7580485149: -0.1%
Covered Lines: 6089
Relevant Lines: 10380

💛 - Coveralls

@J0 J0 force-pushed the j0/add_hook_config branch from 072577d to d8be11a Compare January 18, 2024 05:35
@J0 J0 marked this pull request as ready for review January 18, 2024 07:10
@J0 J0 requested a review from a team as a code owner January 18, 2024 07:10
internal/utils/config.go Outdated Show resolved Hide resolved
internal/utils/config.go Outdated Show resolved Hide resolved
internal/utils/config.go Outdated Show resolved Hide resolved
@J0 J0 requested a review from sweatybridge January 19, 2024 07:13
@J0 J0 enabled auto-merge January 19, 2024 07:41
@sweatybridge sweatybridge disabled auto-merge January 19, 2024 07:42
@sweatybridge sweatybridge enabled auto-merge (squash) January 19, 2024 07:42
@sweatybridge sweatybridge merged commit b380dfb into main Jan 19, 2024
9 checks passed
@sweatybridge sweatybridge deleted the j0/add_hook_config branch January 19, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants