Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add enable manual linking option to auth config #1846

Merged
merged 7 commits into from
Jan 16, 2024

Conversation

mosnicholas
Copy link
Contributor

What kind of change does this PR introduce?

Allow us to test manual linking in localhost

What is the current behavior?

Please link any relevant issues here.

What is the new behavior?

It allows you to specify config.toml value that lets us test manual linking locally

Additional context

Add any other context or screenshots.

@mosnicholas mosnicholas requested a review from a team as a code owner January 16, 2024 01:38
@coveralls
Copy link

coveralls commented Jan 16, 2024

Pull Request Test Coverage Report for Build 7542928339

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.03%) to 58.587%

Totals Coverage Status
Change from base Build 7539446499: -0.03%
Covered Lines: 6038
Relevant Lines: 10306

💛 - Coveralls

@mosnicholas
Copy link
Contributor Author

@hf / @sweatybridge / @kangmingtay I can't request review, so pinging here for visibility :)

Copy link
Contributor

@sweatybridge sweatybridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. Just a few nitpicks.

internal/start/start.go Outdated Show resolved Hide resolved
internal/utils/config.go Outdated Show resolved Hide resolved
internal/utils/templates/init_config.toml Show resolved Hide resolved
@mosnicholas
Copy link
Contributor Author

Thanks @sweatybridge, updated :)

internal/utils/config.go Outdated Show resolved Hide resolved
@mosnicholas
Copy link
Contributor Author

@sweatybridge thanks for the guiding! Is it easy to get this out? :D would love to start building and testing against it.

@sweatybridge sweatybridge changed the title Update start.go fix: add enable manual linking option to auth config Jan 16, 2024
@sweatybridge sweatybridge merged commit 3653ce3 into supabase:main Jan 16, 2024
9 checks passed
@sweatybridge
Copy link
Contributor

Yup, it's good to go. Once main branch is done building, the updated cli will be released to beta channel.

You can run it with npx supabase@beta help

@mosnicholas mosnicholas deleted the patch-1 branch January 16, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants