fix(db): failed start should not remove backup volume #1810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sweatybridge
force-pushed
the
keep-vol
branch
4 times, most recently
from
35cb8f6 to
e04a274
Compare
Pull Request Test Coverage Report for Build 7471101573
💛 - Coveralls |
sweatybridge
force-pushed
the
keep-vol
branch
from
e04a274 to
7e9941c
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix supabase/supabase#17791
What is the current behavior?
If there's a local backup volume and db start encounters an error, the backup volume is deleted.
What is the new behavior?
If backup volume exists, failed start should not remove them. Otherwise if it's a fresh start, delete any backup volume.
Also in this PR:
Additional context
Add any other context or screenshots.