Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: --create-ticket flag to send error reports to sentry #1746

Merged
merged 10 commits into from
Dec 18, 2023

Conversation

sweatybridge
Copy link
Contributor

@sweatybridge sweatybridge commented Dec 12, 2023

What kind of change does this PR introduce?

feature

What is the new behavior?

Reports error to sentry when any commands are with --create-ticket flag. Helps to collect diagnostics information.

  • server side rate limiting
  • add stacktrace to all errors

Going forward, any errors from external packages should be wrapped in errors.New(err) using go-errors.

Additional context

Eg: https://supabase.sentry.io/issues/4734608486/events/e250b9cc83c245d1aa520f1e3ece5017

@coveralls
Copy link

coveralls commented Dec 12, 2023

Pull Request Test Coverage Report for Build 7244995311

  • 305 of 649 (47.0%) changed or added relevant lines in 125 files are covered.
  • 13 unchanged lines in 7 files lost coverage.
  • Overall coverage increased (+0.1%) to 58.272%

Changes Missing Coverage Covered Lines Changed/Added Lines %
cmd/sslEnforcement.go 0 1 0.0%
cmd/start.go 0 1 0.0%
internal/branches/delete/delete.go 0 1 0.0%
internal/branches/get/get.go 0 1 0.0%
internal/branches/update/update.go 0 1 0.0%
internal/encryption/get/get.go 0 1 0.0%
internal/encryption/update/update.go 0 1 0.0%
internal/functions/new/new.go 2 3 66.67%
internal/hostnames/activate/activate.go 0 1 0.0%
internal/hostnames/create/create.go 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
cmd/start.go 1 56.25%
internal/inspect/role_connections/role_connections.go 1 0.0%
internal/postgresConfig/get/get.go 1 0.0%
internal/utils/access_token.go 1 97.67%
internal/utils/misc.go 1 81.61%
internal/debug/postgres.go 3 64.86%
internal/gen/keys/keys.go 5 11.76%
Totals Coverage Status
Change from base Build 7217713612: 0.1%
Covered Lines: 5956
Relevant Lines: 10221

💛 - Coveralls

@sweatybridge sweatybridge changed the title feat: send error reports to sentry feat: send anonymous error reports to sentry Dec 12, 2023
@sweatybridge sweatybridge force-pushed the sentry-sdk branch 2 times, most recently from 58e9648 to 861d939 Compare December 12, 2023 15:46
Copy link

Integrate sentry sdk

@sweatybridge sweatybridge force-pushed the sentry-sdk branch 4 times, most recently from 4fdd5a0 to 566a30b Compare December 16, 2023 04:37
@sweatybridge sweatybridge force-pushed the sentry-sdk branch 2 times, most recently from 79b74c0 to 13bda4a Compare December 17, 2023 08:00
@soedirgo
Copy link
Member

Telemetry is a very sensitive topic, even for anonymous info. IMO we should make this opt-in by prompting on first run instead of opt-out.

@soedirgo soedirgo changed the title feat: send anonymous error reports to sentry feat: --create-ticket flag to send error reports to sentry Dec 18, 2023
.goreleaser.yml Outdated Show resolved Hide resolved
Copy link
Member

@soedirgo soedirgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note re: Windows ARM, otherwise lgtm 👍

@sweatybridge sweatybridge merged commit cb4ce0d into main Dec 18, 2023
9 checks passed
@sweatybridge sweatybridge deleted the sentry-sdk branch December 18, 2023 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants