-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: --create-ticket
flag to send error reports to sentry
#1746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sweatybridge
force-pushed
the
sentry-sdk
branch
from
December 12, 2023 15:37
985a54c
to
e7d1737
Compare
Pull Request Test Coverage Report for Build 7244995311
💛 - Coveralls |
sweatybridge
changed the title
feat: send error reports to sentry
feat: send anonymous error reports to sentry
Dec 12, 2023
sweatybridge
force-pushed
the
sentry-sdk
branch
2 times, most recently
from
December 12, 2023 15:46
58e9648
to
861d939
Compare
sweatybridge
force-pushed
the
sentry-sdk
branch
4 times, most recently
from
December 16, 2023 04:37
4fdd5a0
to
566a30b
Compare
sweatybridge
force-pushed
the
sentry-sdk
branch
2 times, most recently
from
December 17, 2023 08:00
79b74c0
to
13bda4a
Compare
sweatybridge
force-pushed
the
sentry-sdk
branch
from
December 17, 2023 08:08
13bda4a
to
7177350
Compare
sweatybridge
force-pushed
the
sentry-sdk
branch
from
December 18, 2023 06:02
09fbf1f
to
5fd1efc
Compare
soedirgo
changed the title
feat: send anonymous error reports to sentry
feat: Dec 18, 2023
--create-ticket
flag to send error reports to sentry
soedirgo
reviewed
Dec 18, 2023
soedirgo
approved these changes
Dec 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a note re: Windows ARM, otherwise lgtm 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
feature
What is the new behavior?
Reports error to sentry when any commands are with
--create-ticket
flag. Helps to collect diagnostics information.Going forward, any errors from external packages should be wrapped in
errors.New(err)
using go-errors.Additional context
Eg: https://supabase.sentry.io/issues/4734608486/events/e250b9cc83c245d1aa520f1e3ece5017