Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: default preview branch name to local git branch #1707

Merged
merged 1 commit into from
Dec 4, 2023
Merged

fix: default preview branch name to local git branch #1707

merged 1 commit into from
Dec 4, 2023

Conversation

sweatybridge
Copy link
Contributor

@sweatybridge sweatybridge commented Dec 4, 2023 •
edited
Loading

What kind of change does this PR introduce?

Bug fix, feature, docs update, ...

What is the new behavior?

Aligns with frontend naming convention, ie. branch name == git branch
Makes <name> arg optional for backwards compatibility.

Additional context

Add any other context or screenshots.

@sweatybridge sweatybridge requested a review from a team as a code owner December 4, 2023 03:34
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7081692953

  • 0 of 3 (0.0%) changed or added relevant lines in 1 file are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.05%) to 58.193%
Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/branches/create/create.go 0 3 0.0%
Files with Coverage Reduction New Missed Lines %
internal/gen/keys/keys.go 5 12.31%
Totals Coverage Status
Change from base Build 7081070750: -0.05%
Covered Lines: 5803
Relevant Lines: 9972
💛 - Coveralls

@sweatybridge sweatybridge merged commit f90772d into main Dec 4, 2023
11 checks passed
@sweatybridge sweatybridge deleted the opt-name branch December 4, 2023 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soedirgo soedirgo soedirgo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sweatybridge @coveralls @soedirgo