Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add auth session timeouts #1632

Closed
wants to merge 1 commit into from
Closed

feat: add auth session timeouts #1632

wants to merge 1 commit into from

Conversation

hf
Copy link
Contributor

@hf hf commented Nov 2, 2023

Adds the Auth session timeouts configs to the CLI.

@hf hf requested a review from a team as a code owner November 2, 2023 11:52
@hf hf changed the title feat: add auht session timeouts feat: add auth session timeouts Nov 2, 2023
kamilogorek
kamilogorek approved these changes Nov 2, 2023
View reviewed changes
Copy link
Member

@kamilogorek kamilogorek left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ref: supabase/auth#1288
ref: https://github.com/supabase/infrastructure/pull/15533/

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6732150994

  • 3 of 7 (42.86%) changed or added relevant lines in 1 file are covered.
  • 8 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.05%) to 58.549%
Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/start/start.go 3 7 42.86%
Files with Coverage Reduction New Missed Lines %
internal/debug/postgres.go 3 64.86%
internal/gen/keys/keys.go 5 12.31%
Totals Coverage Status
Change from base Build 6703033502: -0.05%
Covered Lines: 5664
Relevant Lines: 9674
💛 - Coveralls

@hf
Copy link
Contributor Author

hf commented Nov 2, 2023

Don't merge until fully released!

@kamilogorek
Copy link
Member

kamilogorek commented Nov 2, 2023 •
edited
Loading

image

😄

@sweatybridge
Copy link
Contributor

Is this safe to merge?

@sweatybridge
Copy link
Contributor

closing due to staleness

@hf
Copy link
Contributor Author

hf commented Jun 14, 2024

Sorry about that. Addressed the comments!

@hf hf mentioned this pull request Jun 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sweatybridge sweatybridge sweatybridge left review comments

@kamilogorek kamilogorek kamilogorek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hf @coveralls @kamilogorek @sweatybridge