Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prune local docker network by label #1601

Merged
merged 2 commits into from
Oct 23, 2023
Merged

fix: prune local docker network by label #1601

merged 2 commits into from
Oct 23, 2023

Conversation

sweatybridge
Copy link
Contributor

What kind of change does this PR introduce?

relates to #1581

What is the new behavior?

Deletes custom network by label.

Additional context

Add any other context or screenshots.

@sweatybridge sweatybridge requested a review from a team as a code owner October 23, 2023 08:24
kamilogorek
kamilogorek approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@kamilogorek kamilogorek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why tests are failing, but change looks good.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6611559944

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 56.917%
Files with Coverage Reduction New Missed Lines %
internal/gen/keys/keys.go 5 12.31%
Totals Coverage Status
Change from base Build 6610269999: -0.02%
Covered Lines: 5188
Relevant Lines: 9115
💛 - Coveralls

@sweatybridge sweatybridge merged commit fbf5903 into main Oct 23, 2023
8 checks passed
@sweatybridge sweatybridge deleted the network-prune branch October 23, 2023 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamilogorek kamilogorek kamilogorek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sweatybridge @coveralls @kamilogorek